Add missing SPDX-License tags#591
Merged
rsmarples merged 3 commits intoNetworkConfiguration:masterfrom Apr 30, 2026
Merged
Conversation
If copyright block is present, add missing SPDX-License tag If copyright block is not present, add one. Use BSD-3-Clause and infer author list from git blame. Resolves NetworkConfiguration#570
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds SPDX-License-Identifier lines and copyright header comments across many files (docs, build files, scripts, source headers/sources, tests, vendor). In files with existing SPDX markers the header lines were repositioned within the file prologue. No functional code, build logic, or public APIs were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Contributor
|
@rsmarples can we merge this? |
Member
|
@perkelix no, sorry I missed reviewing this @ColinMcInnes why BSD-3? My default license, is BSD-2 which covers the whole project. |
Contributor
Author
That was a misread on my part, for some reason I saw BSD-3 in a few files and assumed it was the universal license, but that was just for a few items, I will fix that. |
Contributor
Author
|
Now the only BSD-3 is the 3 files from University of California (Berkley) |
Overall project is BSD-2, not 3, so ensure any new license header was BSD-2. General formatting cleanup.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hooks/dhcpcd-run-hooks.8.in`:
- Line 1: The SPDX header string is inconsistent with the license body; update
the SPDX identifier or the license prose so they match: either change the SPDX
tag from "BSD-2-Clause" to "BSD-2-Clause-NetBSD" to reflect the NetBSD-style
“author and contributors” wording, or replace the embedded license text with the
canonical BSD-2-Clause wording; ensure the value in the header (the string on
the first line) exactly matches the variant used in the license block below so
scanners and legal tooling stay accurate.
In `@hooks/dhcpcd-run-hooks.in`:
- Around line 2-3: Update the file header comments: replace the outdated
copyright line ("# Copyright (c) 2017-2022 Roy Marples <roy@marples.name>") with
the correct year range and author attribution found in the repo history (e.g. "#
Copyright (c) 2017-2026 Colin McInnes <...>") or otherwise adjust the
range/author to match contribution history; keep the existing SPDX line intact
and, if unsure about retaining Roy Marples as co-author, add a note or consult
maintainers to decide whether to list both authors or only Colin McInnes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c62882f8-9d25-4d1a-ad65-e6452e4423c1
📒 Files selected for processing (148)
BUILDING.mdMakefileMakefile.incREADME.mdcompat/_strtoi.hcompat/arc4random.ccompat/arc4random.hcompat/arc4random_uniform.ccompat/arc4random_uniform.hcompat/bitops.hcompat/chacha_private.hcompat/closefrom.hcompat/consttime_memequal.hcompat/crypt/hmac.ccompat/crypt/hmac.hcompat/crypt/md5.ccompat/crypt/md5.hcompat/crypt/sha256.ccompat/crypt/sha256.hcompat/crypt_openssl/hmac.ccompat/crypt_openssl/hmac.hcompat/crypt_openssl/sha256.ccompat/crypt_openssl/sha256.hcompat/dprintf.ccompat/dprintf.hcompat/endian.hcompat/pidfile.ccompat/pidfile.hcompat/queue.hcompat/reallocarray.ccompat/reallocarray.hcompat/setproctitle.ccompat/setproctitle.hcompat/strlcpy.ccompat/strlcpy.hcompat/strtoi.ccompat/strtoi.hcompat/strtou.cconfig-null.mkconfigurehooks/01-testhooks/10-wpa_supplicanthooks/15-timezonehooks/20-resolv.confhooks/29-lookup-hostnamehooks/30-hostname.inhooks/50-dhcpcd-compathooks/50-ntp.confhooks/50-timesyncd.confhooks/50-yp.confhooks/50-ypbind.inhooks/Makefilehooks/dhcpcd-run-hooks.8.inhooks/dhcpcd-run-hooks.iniconfig.mksrc/GNUmakefilesrc/Makefilesrc/arp.csrc/arp.hsrc/auth.csrc/auth.hsrc/bpf.csrc/bpf.hsrc/common.csrc/common.hsrc/control.csrc/control.hsrc/defs.hsrc/dev.csrc/dev.hsrc/dev/Makefilesrc/dev/udev.csrc/dhcp-common.csrc/dhcp-common.hsrc/dhcp.csrc/dhcp.hsrc/dhcp6.csrc/dhcp6.hsrc/dhcpcd-definitions-small.confsrc/dhcpcd-definitions.confsrc/dhcpcd-embedded.c.insrc/dhcpcd-embedded.h.insrc/dhcpcd.8.insrc/dhcpcd.csrc/dhcpcd.confsrc/dhcpcd.conf.5.insrc/dhcpcd.hsrc/duid.csrc/duid.hsrc/eloop.csrc/eloop.hsrc/genembedcsrc/genembedhsrc/if-bsd.csrc/if-linux-wext.csrc/if-linux.csrc/if-options.csrc/if-options.hsrc/if-sun.csrc/if.csrc/if.hsrc/ipv4.csrc/ipv4.hsrc/ipv4ll.csrc/ipv4ll.hsrc/ipv6.csrc/ipv6.hsrc/ipv6nd.csrc/ipv6nd.hsrc/logerr.csrc/logerr.hsrc/privsep-bpf.csrc/privsep-bpf.hsrc/privsep-bsd.csrc/privsep-control.csrc/privsep-control.hsrc/privsep-inet.csrc/privsep-inet.hsrc/privsep-linux.csrc/privsep-root.csrc/privsep-root.hsrc/privsep-sun.csrc/privsep.csrc/privsep.hsrc/queue.hsrc/route.csrc/route.hsrc/sa.csrc/sa.hsrc/script.csrc/script.htests/Makefiletests/crypt/.gitignoretests/crypt/GNUmakefiletests/crypt/Makefiletests/crypt/README.mdtests/crypt/run-test.ctests/crypt/test.htests/crypt/test_hmac_md5.ctests/crypt/test_sha256.ctests/eloop-bench/.gitignoretests/eloop-bench/Makefiletests/eloop-bench/README.mdtests/eloop-bench/eloop-bench.cvendor/README.mdvendor/queue.hvendor/rbtree.cvendor/rbtree.h
💤 Files with no reviewable changes (3)
- compat/closefrom.h
- src/dhcpcd.conf.5.in
- src/dhcpcd.8.in
Contributor
|
@rsmarples are we good to go now? |
rsmarples
reviewed
Apr 30, 2026
Brain fart, I put it right before the line containing "copyright" but that was in the middle of a sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If copyright block is present, add missing SPDX-License tag
If copyright block is not present, add one. Use BSD-3-Clause and infer author list from git blame.
Resolves #570