Skip to content

Fix buffer overflow in the ANSI boot.config redirect hook #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManlyMarco merged 2 commits into from
Jun 22, 2026
+11 −8
Merged

Fix buffer overflow in the ANSI boot.config redirect hook #106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f52a349
Fix buffer overflow in the ANSI boot.config redirect hook
HetCreep Jun 21, 2026
f922e00
Apply suggestion from @ManlyMarco
ManlyMarco Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/windows/entrypoint.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ HANDLE WINAPI create_file_hook_narrow(
LPSECURITY_ATTRIBUTES lpSecurityAttributes, DWORD dwCreationDisposition,
DWORD dwFlagsAndAttributes, HANDLE hTemplateFile) {
void *actual_file_name = lpFileName;
char *narrowed_boot_config_override = NULL;

char_t *widened_filename = widen(lpFileName);
char_t *normalised_path =
Expand All @@ -114,19 +115,21 @@ HANDLE WINAPI create_file_hook_narrow(
}

if (strcmpi(normalised_path, default_boot_config_path) == 0) {
char *narrowed_boot_config_override =
narrow(config.boot_config_override);
memcpy(actual_file_name, narrowed_boot_config_override,
strlen(config.boot_config_override));
free(narrowed_boot_config_override);
narrowed_boot_config_override = narrow(config.boot_config_override);
actual_file_name = narrowed_boot_config_override;
LOG("Overriding boot.config to %s", actual_file_name);
}

free(normalised_path);

return CreateFileA(actual_file_name, dwDesiredAccess, dwShareMode,
lpSecurityAttributes, dwCreationDisposition,
dwFlagsAndAttributes, hTemplateFile);
HANDLE result = CreateFileA(actual_file_name, dwDesiredAccess, dwShareMode,
lpSecurityAttributes, dwCreationDisposition,
dwFlagsAndAttributes, hTemplateFile);

if (narrowed_boot_config_override)
free(narrowed_boot_config_override);

return result;
}

void capture_mono_path(void *handle) {
Expand Down
Loading