Swap pv-battery FOM configurations from ptc to ITC#2240
Conversation
brtietz
added
financial
cpaulgilman
left a comment
cpaulgilman
left a comment
There was a problem hiding this comment.
There are some issues here. For example:
PVWatts-Battery / Single Owner has the ITC percentage assigned to Federal Amount instead of Federal Percentage:
Custom Generation-Battery / TPO Host-Developer has ITC percentages set to zero.
I will try to fix these before the release.
Fuel cell state ITC qualification for hybrids to be consistent with fuel cell config
|
@cpaulgilman let me know if you want me to review your changes before merging, or if you're comfortable with them. I'll be online the rest of this afternoon and a bit this weekend (regularly scheduled working hours), as well as Monday. |
|
@janinefreeman I think I fixed all the ITC and depreciation defaults for battery configs. It would be helpful for you to review before this gets merged. Thanks. |
|
DO NOT MERGE YET. Some defaults continue to be wrong, so far I've found the inverter got switched for PV-Wind-Battery Host/Developer such that the DC/AC ratio is 0.11. I will continue investigating and fix what I find on this branch. |
… where the CEC library upgrades left the wrong module or inverter selected. fixes a variety of sizing messages and one very wrong dc/ac ratio
|
It seems that the incorrect defaults were likely a result of the CEC module and inverter library upgrades. I manually checked defaults for all detailed PV, PV-battery, and PV-hybrid configs to make sure they were consistent with what we actually want, and updated the few that were wrong. I reviewed the ITC changes to the best of my ability. I think we are ok to merge but could be worth one more review Monday prior to building. |
…c_ptc_defaults_battery
|
@janinefreeman This looks good now. I merged PVWatts Battery UI form fixes here to test latest defaults with new battery operating cost inputs for PVWatts Battery configs that were using the wrong form. Should be good to merge once CI tests pass. |
3 participants
Pull Request Template
Description
Swap PTC to ITC for batteries
Corresponding branches and PRs:
Develop for other branches
Unit Test Impact:
Updated test_script_ow.lk results for attached defaults changes
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)