feat: add keyboard selection for slash completions#580
Open
miloquinn wants to merge 1 commit into
Open
Conversation
- Track selected slash-completion index in shared UI state - Let Up/Down navigate command completions with wraparound - Let Enter fill the selected slash command and Escape dismiss the menu - Highlight the selected command in the completion list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The slash completion menu was display-only unless there was exactly one match. When multiple commands matched, users could not navigate the menu or select a highlighted command with Enter, even though the UI already showed a completion list.
This implements the keyboard-selection behavior requested in #575 while preserving existing file-autocomplete priority.
Testing
npm run test:typesnpx ava source/hooks/useUIState.spec.ts source/components/user-input.spec.tsx --timeout=60snpm run test:format -- source/hooks/useUIState.ts source/hooks/useUIState.spec.ts source/components/user-input.tsx source/components/user-input.spec.tsxgit diff --checkNote:
test:formatreports existing Biome config schema/deprecation infos, but no formatting errors after this change.