fix: forward resolved context limit to Ollama#579
Open
zerone0x wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the missing runtime half of #485 for Ollama-backed models.
Nanocoder already let users configure context limits via:
/context-max/--context-maxcontextWindowcontextWindowscontextWindowBut those limits were only used inside Nanocoder for context accounting and auto-compact decisions. They were not being forwarded to Ollama itself, so the actual model runtime could still use a different context size.
This change now forwards the resolved Nanocoder context limit to Ollama as
options.num_ctxon each request, so the configured limit affects the real runtime behavior too.It also updates the docs to make that behavior explicit.
Type of Change
Testing
Automated Tests
.spec.ts/tsxfilespnpm test:allcompletes successfully)Ran:
npm exec --yes pnpm -- test:ava source/ai-sdk-client/chat/provider-options.spec.tsnpm exec --yes pnpm -- test:typesnpm exec --yes pnpm -- exec biome check source/ai-sdk-client/chat/provider-options.ts source/ai-sdk-client/chat/provider-options.spec.ts source/ai-sdk-client/chat/chat-handler.ts docs/configuration/providers/ollama.md docs/features/subagents.mdManual Testing
Manual testing was not run in this environment.
Checklist
Closes #485