Skip to content

[i18n] Remove unused tutorial_4/5 locale strings#981

Merged
Nain57 merged 1 commit into
Nain57:dev-4.0.0-beta05-fixesfrom
BoringMan314:fix/i18n-tutorial-cleanup-and-missing-strings
Jul 15, 2026
Merged

[i18n] Remove unused tutorial_4/5 locale strings#981
Nain57 merged 1 commit into
Nain57:dev-4.0.0-beta05-fixesfrom
BoringMan314:fix/i18n-tutorial-cleanup-and-missing-strings

Conversation

@BoringMan314

@BoringMan314 BoringMan314 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove obsolete item_title/desc_tutorial_4 and item_title/desc_tutorial_5 from all locales
  • Add missing combine_conditions_not_visible translations: steps 18–24 and step_secondary_18

Scope

  • feature/tutorial/src/main/res/values-*

@BoringMan314
BoringMan314 force-pushed the fix/i18n-tutorial-cleanup-and-missing-strings branch from 6de5a6e to b13944f Compare July 14, 2026 15:04
@Nain57
Nain57 changed the base branch from master to dev-4.0.0-beta05-fixes July 15, 2026 08:27

@Nain57 Nain57 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You again included commits not related to the fix. Please ensure branch cleaness before pushing.

If we remove the irrelevant commits and the translations, it only leaves the unused strings.
Do as you wish, you can drop the PR and i will clean it during the cleaning pass before final release, or you can update this PR.


<string name="message_tutorial_combine_conditions_not_visible_target_step_17">تهانينا!\n\nأنت تعرف الآن كيفية الجمع بين شروط متعددة لحدث ما،
ولكن هناك الكثير لنتعلمه!</string>
<string name="message_tutorial_combine_conditions_not_visible_target_step_18">تحتاج إلى تحديد الموضع الدقيق للنقر، لذا أعد تشغيل اللعبة لعرض الشخصية الزرقاء ثم حدد موضعها.\n\nبمجرد أن يكون الموضع صحيحًا، انقر على زر التحقق لحفظه.</string>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tutorial development is not finished and those steps are not correct one. As stated in the release notes, i'm still working on them for the final beta, sorry if this made you work for nothing.

Default values no longer define these keys; drop leftover translations.
@BoringMan314
BoringMan314 force-pushed the fix/i18n-tutorial-cleanup-and-missing-strings branch from 0acc391 to 1896a03 Compare July 15, 2026 10:51
@BoringMan314

Copy link
Copy Markdown
Contributor Author

Updated: the branch is now a single commit on top of dev-4.0.0-beta05-fixes, and only removes unused tutorial_4 / tutorial_5 locale leftovers. The combine-conditions tutorial string additions were dropped.

@BoringMan314 BoringMan314 changed the title [i18n] Remove obsolete tutorial keys and add missing combine-condition translations [i18n] Remove unused tutorial_4/5 locale strings Jul 15, 2026
@Nain57
Nain57 merged commit d64ab03 into Nain57:dev-4.0.0-beta05-fixes Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants