Vendor first-party utility roles into the repository#1369
Merged
Conversation
The users, hosts, and chrony roles live in the DeepOps GitHub organization but have been frozen since 2021 and were consumed as SHA-pinned Galaxy fetches. Fetch-time installation leaves long-lived checkouts vulnerable to installed-copy drift (an on-disk role predating the requirements pin), the failure mode recently root-caused with the third-party MAAS role, and adds a network dependency for content this project already owns. Copy the three roles into roles/ at their exact pinned commits (provenance recorded in each README), rename to deepops_users / deepops_hosts / deepops_chrony, update the four consuming playbooks, and drop the Galaxy entries. Role content is unchanged.
dholt
marked this pull request as ready for review
July 15, 2026 22:05
michael-balint
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
users,hosts,chronyfrom the DeepOps GitHub organization, frozen since 2021) intoroles/at their exact pinned commits, renameddeepops_users/deepops_hosts/deepops_chrony, with provenance recorded in each README. The four consuming playbooks are updated and the Galaxy entries removed.Validation
git diff --check; full role lint including the newly vendored roles (0 failures); syntax checks for all four consuming playbooks pass with the Galaxy roles uninstalled.Notes
./scripts/setup.shafter upgrading (Galaxy roles refresh with--force), since stale on-disk copies of previously pinned roles can predate the current pins.