Replace third-party MAAS role with a DeepOps-owned controller role#1367
Merged
Conversation
The Galaxy role this playbook depended on has had no functional MAAS changes since 2023, and DeepOps exercised only the single-node install path — roughly six tasks of its surface. It also pip-installed unmaintained MAAS client modules DeepOps never uses into the system interpreter, which fails on Ubuntu 24.04 (PEP 668) and blocks MAAS 3.7 on Noble controllers. Long-lived checkouts additionally risk running a stale on-disk copy of the role that predates the requirements pin and cannot execute on current Ansible at all. Add roles/maas-controller with exactly the used surface: MAAS PPA, package install, idempotent admin-account creation (same marker file as before, so existing deployments do not re-create accounts), and region controller URL configuration. Variable names are unchanged for existing site configs; the unused maas_setup_user / maas_kvm_management / maas_python_reqs knobs are removed from the example config. Fixes nothing user-visible on healthy 22.04 deployments; unblocks Ubuntu 24.04 controllers.
michael-balint
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maas-controllerrole covering exactly the surface this repository uses: MAAS PPA, package install, idempotent admin-account creation, and region controller URL configuration (~70 lines).maas_setup_user/maas_kvm_management/maas_python_reqsknobs are removed from the example config. The Galaxy dependency is removed fromroles/requirements.yml.Validation
playbooks/provisioning/maas.ymlsyntax check passes with the Galaxy role uninstalled — the dependency is genuinely gone.ok=7, failed=0), all MAAS services active, API responding (version 3.5.13, full capability list).Notes