fix: restart containerized exporters when Docker restarts#1363
Merged
Conversation
The monitoring container units (node exporter, DCGM exporter, Slurm exporter, Prometheus, Grafana, Alertmanager) declare Requires=docker.service without PartOf=. When Docker is restarted after the units are up — which the NVIDIA container runtime configuration does during a first slurm-cluster.yml run on GPU nodes — systemd stops the dependent units and nothing starts them again, so exporters stay down until reboot. Add PartOf=docker.service so a Docker restart propagates as a restart to the container units instead of a one-way stop. Fixes #1267
Contributor
Author
Live validation summaryValidated on a disposable dual-GPU server (Ubuntu 22.04) with a fresh full
|
michael-balint
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PartOf=docker.serviceto the six containerized monitoring service units (node exporter, DCGM exporter, Slurm exporter, Prometheus, Grafana, Alertmanager).Requires=docker.servicewithoutPartOf=, so an explicit Docker restart propagates as a one-way stop to the dependents and nothing starts them again. A firstslurm-cluster.ymlrun on GPU nodes triggers exactly this — the NVIDIA container runtime configuration restarts Docker after the node exporter is already up — leaving exporters down until reboot.PartOf=, a Docker restart propagates as a restart, so the units come back automatically (including after any manualsystemctl restart docker).Validation
git diff --check; full role lint: 0 failures, 0 warnings.slurm-cluster.ymlrun, then asserting the node exporter is active at the end of the run and recovers after an explicit Docker restart.Notes