chore: remove ffmpeg via opencv from nss task image#491
Open
mckornfield wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
📝 WalkthroughWalkthroughThe cleanup script now uninstalls OpenCV Python wheel variants from existing virtual environments before continuing the existing ffmpeg binary deletion fallback. ChangesVirtual environment CVE cleanup
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker/scripts/cve-cleanup.sh`:
- Around line 18-22: The OpenCV cleanup in cve-cleanup.sh only uninstalls the
venv packages via uv pip uninstall, so cached hard-linked OpenCV FFmpeg .so
files can still remain under /root/.cache/uv. Update the cleanup logic around
the uv pip uninstall block to also remove the corresponding OpenCV wheel cache
entries from uv’s cache, using the same package names already listed there, so
the scan no longer finds leftover artifacts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: bd2e137b-5a40-47a9-9893-f562625cc051
📒 Files selected for processing (1)
docker/scripts/cve-cleanup.sh
Contributor
|
ironcommit
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit