fix: JSONL files not opening in preview (ASTD-261)#427
Open
marcusds wants to merge 6 commits into
Open
Conversation
The backend HEAD endpoint returns application/octet-stream for all files, causing useIsBinaryFile to incorrectly classify .jsonl and other text files as binary. Added KNOWN_TEXT_EXTENSIONS allowlist that short-circuits the HEAD request for recognized text extensions. - Add 50+ known text extensions (json, jsonl, csv, py, yaml, md, etc.) - Restructure hook to check text extensions before binary blocklist - Add unit tests for useIsBinaryFile hook Signed-off-by: mschwab <mschwab@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesSynchronous binary-file detection
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/components/filesets/hooks/useIsBinaryFile.test.ts`:
- Line 5: The import statement on line 5 mixes value and type imports from
`@tanstack/react-query`. Separate UseQueryResult into a type-only import using
import type syntax, keeping useQuery in the regular import statement. This
follows coding guidelines by explicitly marking type-only imports and allows the
compiler to properly tree-shake unused types.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b07f9cd4-47a7-49c2-946c-0a532a0b5fee
📒 Files selected for processing (2)
web/packages/studio/src/components/filesets/hooks/useIsBinaryFile.test.tsweb/packages/studio/src/components/filesets/hooks/useIsBinaryFile.ts
Contributor
|
…end always returns application/octet-stream Signed-off-by: mschwab <mschwab@nvidia.com>
Signed-off-by: mschwab <mschwab@nvidia.com>
…ilePath Signed-off-by: mschwab <mschwab@nvidia.com>
Signed-off-by: mschwab <mschwab@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/components/filesets/hooks/useIsBinaryFile.test.ts`:
- Around line 32-35: The test named for .yaml and .yml only exercises
useIsBinaryFile with config.yaml, so the .yml allowlist path is unverified;
update the useIsBinaryFile test case to also invoke the hook with a .yml
filename and assert the same { isBinary: false, isLoading: false } result,
keeping the existing yaml check so both extensions are covered.
In `@web/packages/studio/src/components/filesets/hooks/useIsBinaryFile.ts`:
- Around line 18-30: The useIsBinaryFile hook is now failing open for every
unknown extension, which lets non-text files reach preview paths. Keep the
existing fast checks in useIsBinaryFile, but change the fallback for
unrecognized filePath values to perform a real binary detection instead of
returning false; use the existing isKnownTextExtension and isBinaryExtension
helpers as the named entry points to update, and ensure unknown extensions do
not default to text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8e5dad57-33da-4ebe-8302-d885dd6eebfa
📒 Files selected for processing (4)
web/packages/studio/src/components/FilesetFilePreviewPanel/FilesetFilePreviewContent/index.tsxweb/packages/studio/src/components/filesets/hooks/useIsBinaryFile.test.tsweb/packages/studio/src/components/filesets/hooks/useIsBinaryFile.tsweb/packages/studio/src/constants/constants.ts
…yFile Signed-off-by: mschwab <mschwab@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JSONL files were showing 'Text preview not available for binary files' in the fileset preview panel.
Root Cause
The backend HEAD endpoint returns
application/octet-streamfor all files.useIsBinaryFilerelied solely on theContent-Typeheader to determine if a file is text, so.jsonl(and other text files like.json,.csv,.py, etc.) were incorrectly classified as binary.Fix
Added a
KNOWN_TEXT_EXTENSIONSallowlist (50+ extensions) that short-circuits the HEAD request for recognized text file extensions. The detection strategy is now four-tiered:KNOWN_TEXT_EXTENSIONS→ text immediately (no network)BINARY_FILE_EXTENSIONS→ binary immediately (no network)Content-TypedecidesChanges
useIsBinaryFile.ts: AddedKNOWN_TEXT_EXTENSIONSset andisKnownTextExtensionhelper. Restructured hook to check text extensions before binary blocklist.useIsBinaryFile.test.ts: New test file with 10 tests covering JSONL, JSON, CSV, PY, YAML, MD, undefined path, PNG, ZIP, and unknown extensions.Summary by CodeRabbit
.json,.csv,.py,.yaml,.md) without server requests.isLoadingis no longer used, and unknown extensions default to non-binary.KNOWN_TEXT_EXTENSIONSconstant.