-
Notifications
You must be signed in to change notification settings - Fork 193
chore: add nvidia-internal deploymentType to telemetry enum #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5415a58
chore: add nvidia-internal deploymentType to telemetry enum
mckornfield 1308d00
chore: add unit tests for telemetry
mckornfield f3045bc
chore: follow project setup for tests
mckornfield bf5ac62
Merge branch 'main' into add-nv-internal/mck
nabinchha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
packages/data-designer-engine/tests/engine/models/test_telemetry.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
mckornfield marked this conversation as resolved.
|
||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from datetime import datetime, timezone | ||
|
|
||
| from data_designer.engine.models.telemetry import ( | ||
| DeploymentTypeEnum, | ||
| InferenceEvent, | ||
| NemoSourceEnum, | ||
| QueuedEvent, | ||
| TaskStatusEnum, | ||
| build_payload, | ||
| ) | ||
|
|
||
|
|
||
| def test_nvidia_internal_deployment_type_uses_schema_version_1_9() -> None: | ||
| event = InferenceEvent( | ||
| nemo_source=NemoSourceEnum.DATADESIGNER, | ||
| task="batch", | ||
| task_status=TaskStatusEnum.SUCCESS, | ||
| deployment_type=DeploymentTypeEnum("nvidia-internal"), | ||
| model="test-model", | ||
| ) | ||
| payload = build_payload( | ||
| [QueuedEvent(event=event, timestamp=datetime(2026, 7, 2, tzinfo=timezone.utc))], | ||
| source_client_version="test", | ||
| ) | ||
|
|
||
| assert payload["eventSchemaVer"] == "1.9" | ||
| assert payload["events"][0]["parameters"]["deploymentType"] == "nvidia-internal" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.