Skip to content

DOCUMENTATION: fre make refinement #891

Open
mlee03 wants to merge 14 commits into
NOAA-GFDL:mainfrom
mlee03:fremake-doc-predicate
Open

DOCUMENTATION: fre make refinement #891
mlee03 wants to merge 14 commits into
NOAA-GFDL:mainfrom
mlee03:fremake-doc-predicate

Conversation

@mlee03

@mlee03 mlee03 commented May 14, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

This PR

  1. modifies the :param docstrings to be in predicate form. For example,
    :param variable random variable
    changed to
    :param variable. is a random variable
    This change will help when parsing the docstrings to create a vector database for the chatbot.

  2. added slightly more detailed information to current documentation with the help of AI coding assistant.

Issue ticket number and link (if applicable)

Fixes #XXX (replace XXX with the issue number and GitHub will autolink the PR to the issue)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

mlee03 and others added 3 commits May 14, 2026 09:31
@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.09%. Comparing base (ad94447) to head (df4185a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          67       67           
  Lines        3736     3736           
=======================================
  Hits         3067     3067           
  Misses        669      669           
Flag Coverage Δ
unittests 82.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/make/create_checkout_script.py 97.46% <ø> (ø)
fre/make/create_compile_script.py 97.87% <ø> (ø)
fre/make/create_docker_script.py 100.00% <ø> (ø)
fre/make/create_makefile_script.py 97.67% <ø> (ø)
fre/make/fremake.py 95.58% <100.00%> (ø)
fre/make/make_helpers.py 100.00% <ø> (ø)
fre/make/run_fremake_script.py 97.95% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad94447...df4185a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mlee03 mlee03 marked this pull request as ready for review May 18, 2026 17:21
@mlee03 mlee03 requested review from Ciheim, Copilot, laurenchilutti, meteorologist15, rem1776 and singhd789 and removed request for Copilot and singhd789 May 18, 2026 17:21
@mlee03

mlee03 commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

I'm still editing the content, but it is open for review!

Comment thread fre/make/create_docker_script.py Outdated
Comment thread fre/make/create_docker_script.py Outdated
Comment thread fre/make/create_checkout_script.py Outdated
Comment thread fre/make/create_checkout_script.py Outdated
Comment thread fre/make/create_checkout_script.py
Comment thread fre/make/create_makefile_script.py Outdated
Comment thread fre/make/fremake.py Outdated
Comment thread fre/make/make_helpers.py Outdated
Comment thread fre/make/run_fremake_script.py Outdated
Comment thread fre/make/fremake.py
@mlee03 mlee03 requested a review from singhd789 July 1, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants