Fix no central orders and completely empty grids in scale variations#248
Open
Radonirinaunimi wants to merge 11 commits intomainfrom
Open
Fix no central orders and completely empty grids in scale variations#248Radonirinaunimi wants to merge 11 commits intomainfrom
Radonirinaunimi wants to merge 11 commits intomainfrom
Conversation
Member
Author
|
@kamillaurent Could you please check with this branch (say for one of the datasets and sub-theories that failed before) that it is no longer an issue? |
|
@Radonirinaunimi I checked and seems the problem is no longer there. However, for these datasets: I still encounter the second error: |
Member
Author
|
Could you please try now @kamillaurent ? (Fingers crossed 🤞🏼 it won't break the nFONLL combinations) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues arising from specific grids during scale variations, namely:
PS: It also bumps the version of
pineappltov1.4.0a1for the tests.