Skip to content

Chore: [AEA-6520] - Adopt CDK deployment#2549

Open
tstephen-nhs wants to merge 9 commits intomainfrom
aea-6257-add-cdk-to-ci-release
Open

Chore: [AEA-6520] - Adopt CDK deployment#2549
tstephen-nhs wants to merge 9 commits intomainfrom
aea-6257-add-cdk-to-ci-release

Conversation

@tstephen-nhs
Copy link
Copy Markdown
Contributor

@tstephen-nhs tstephen-nhs commented Apr 10, 2026

Summary

  • 🤖 Operational or Infrastructure Change

Details

Following New: [AEA-6257] - scaffold app with CDK this PR adopts CDK deployment for CI and release.

This needs the GitHub repo setting for 'required' checks to be switched

  • from package_code/sam_package_code to package_code/cdk_package_code and
  • release_code/sam_release_code to release_code/cdk_release_code

SAM templates, .github/scripts, etc. are left in place for now in case of a need to revert.

@tstephen-nhs tstephen-nhs force-pushed the aea-6257-add-cdk-to-ci-release branch from ec9ea75 to 75fb6b4 Compare April 23, 2026 10:23
@anthony-nhs anthony-nhs temporarily deployed to create_pull_request April 23, 2026 10:33 — with GitHub Actions Inactive
@tstephen-nhs tstephen-nhs reopened this Apr 23, 2026
@tstephen-nhs tstephen-nhs force-pushed the aea-6257-add-cdk-to-ci-release branch from d99a4bf to e972519 Compare April 24, 2026 13:59
@tstephen-nhs tstephen-nhs marked this pull request as ready for review April 24, 2026 14:18
Copilot AI review requested due to automatic review settings April 24, 2026 14:18
@tstephen-nhs tstephen-nhs enabled auto-merge (squash) April 24, 2026 14:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adopts CDK-based packaging/deployment in CI and release pipelines (keeping SAM templates in place for fallback), and aligns supporting scripts/config with the new CDK deployment approach.

Changes:

  • Switch CI and release workflows from SAM package/release to CDK package/release workflows, updating stack names/artifact names and required secrets.
  • Update cleanup automation to delete old PR CDK stacks via a CDK workspace script and refresh zizmor ignore locations for unpinned container images.
  • Centralise the API identifier (pfp-api) into a CDK constant and update CDK apps/scripts to use it; update lockfile dependencies.

Reviewed changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
zizmor.yml Updates zizmor ignore locations for unpinned images in modified workflows.
trivy.yaml Removes obsolete Trivy ignorefile config line.
packages/cdk/tsconfig.json Ensures new constants.ts is included in compilation.
packages/cdk/scripts/deletePrStacks.ts Uses shared API_NAME constant for PR stack cleanup.
packages/cdk/scripts/deleteMainStacks.ts Uses shared API_NAME and updates active API version source used for cleanup.
packages/cdk/constants.ts Introduces shared API_NAME constant for CDK-related scripts/apps.
packages/cdk/bin/PfPApiSandboxApp.ts Uses API_NAME for drift detection grouping.
packages/cdk/bin/PfPApiApp.ts Uses API_NAME for drift detection grouping.
package-lock.json Dependency updates related to XML parsing/building packages.
.github/workflows/sam_release_code.yml Removes unused workflow-call inputs for release notes creation.
.github/workflows/release.yml Switches release orchestration to CDK workflows and updates inputs/secrets accordingly.
.github/workflows/pull_request.yml Updates to newer common workflow SHAs (and continues CDK PR deployments).
.github/workflows/delete_old_cloudformation_stacks.yml Reworks cleanup workflow to use pinned devcontainer image + workspace scripts for PR stack deletion.
.github/workflows/ci.yml Switches CI deployment stages to CDK workflows and updates inputs/secrets accordingly.
.github/workflows/cdk_release_code.yml Removes unused workflow-call inputs for release notes creation.

Comment thread .github/workflows/delete_old_cloudformation_stacks.yml
Comment thread zizmor.yml
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants