Open
Conversation
ec9ea75 to
75fb6b4
Compare
1f1c950 to
8b7b14e
Compare
d99a4bf to
e972519
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adopts CDK-based packaging/deployment in CI and release pipelines (keeping SAM templates in place for fallback), and aligns supporting scripts/config with the new CDK deployment approach.
Changes:
- Switch CI and release workflows from SAM package/release to CDK package/release workflows, updating stack names/artifact names and required secrets.
- Update cleanup automation to delete old PR CDK stacks via a CDK workspace script and refresh zizmor ignore locations for unpinned container images.
- Centralise the API identifier (
pfp-api) into a CDK constant and update CDK apps/scripts to use it; update lockfile dependencies.
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
zizmor.yml |
Updates zizmor ignore locations for unpinned images in modified workflows. |
trivy.yaml |
Removes obsolete Trivy ignorefile config line. |
packages/cdk/tsconfig.json |
Ensures new constants.ts is included in compilation. |
packages/cdk/scripts/deletePrStacks.ts |
Uses shared API_NAME constant for PR stack cleanup. |
packages/cdk/scripts/deleteMainStacks.ts |
Uses shared API_NAME and updates active API version source used for cleanup. |
packages/cdk/constants.ts |
Introduces shared API_NAME constant for CDK-related scripts/apps. |
packages/cdk/bin/PfPApiSandboxApp.ts |
Uses API_NAME for drift detection grouping. |
packages/cdk/bin/PfPApiApp.ts |
Uses API_NAME for drift detection grouping. |
package-lock.json |
Dependency updates related to XML parsing/building packages. |
.github/workflows/sam_release_code.yml |
Removes unused workflow-call inputs for release notes creation. |
.github/workflows/release.yml |
Switches release orchestration to CDK workflows and updates inputs/secrets accordingly. |
.github/workflows/pull_request.yml |
Updates to newer common workflow SHAs (and continues CDK PR deployments). |
.github/workflows/delete_old_cloudformation_stacks.yml |
Reworks cleanup workflow to use pinned devcontainer image + workspace scripts for PR stack deletion. |
.github/workflows/ci.yml |
Switches CI deployment stages to CDK workflows and updates inputs/secrets accordingly. |
.github/workflows/cdk_release_code.yml |
Removes unused workflow-call inputs for release notes creation. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Details
Following New: [AEA-6257] - scaffold app with CDK this PR adopts CDK deployment for CI and release.
This needs the GitHub repo setting for 'required' checks to be switched
SAM templates, .github/scripts, etc. are left in place for now in case of a need to revert.