CCM-16035 Update deploy worfklow#536
Open
francisco-videira-nhs wants to merge 11 commits intomainfrom
Open
Conversation
|
|
||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4 |
Contributor
Author
There was a problem hiding this comment.
Are we sure we want to get rid of deploying these pages? Discussion was that we are already doing this on publish, but publish doesn't deploy the docs to github pages - unless we don't want to do that anymore
| type: choice | ||
| required: true | ||
| default: internal-dev | ||
| options: |
Contributor
Author
There was a problem hiding this comment.
Do we still use ref?
| default: dev | ||
| options: | ||
| - dev | ||
| - nonprod |
Contributor
Author
There was a problem hiding this comment.
Currently there's no approvals step for nonprod deployments (as in prod). If I accidentally deploy something to nonprod via https://github.com/NHSDigital/nhs-notify-internal/actions/workflows/dispatch-deploy-static-notify-supplier-api-env.yaml (or this new deploy worflow) and it passes, it will be deployed...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.