CCM-16444 config seeding for dynamic envs#532
Conversation
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
2 times, most recently
from
9b04a23 to
3f66c94
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
2 times, most recently
from
551f2e2 to
777b1e0
Compare
| --overrideProjectName "nhs" \ | ||
| --overrideRoleName "nhs-main-acct-supplier-api-github-deploy" | ||
| --overrideRoleName "nhs-main-acct-supplier-api-github-deploy" \ | ||
| --internalRef "feature/CCM-12444-supplier-config-publishing-workflow" |
There was a problem hiding this comment.
I presume this needs taking out before this branch is merged, and after the internal branch is merged?
| --targetComponent "config" \ | ||
| --targetAccountGroup "nhs-notify-suppliers-dev" \ | ||
| --tableName "supplier-config" \ | ||
| --internalRef "feature/CCM-12444-supplier-config-publishing-workflow" \ |
There was a problem hiding this comment.
Please remove references to internal campaign config
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
3 times, most recently
from
23aa898 to
de7cb87
Compare
| runId: "${{ github.run_id }}" | ||
| buildSandbox: true | ||
| releaseVersion: ${{ github.head_ref || github.ref_name }} | ||
| populate-config: |
There was a problem hiding this comment.
Minor, but populate-config could go before artefact-proxies, so we have the backend stuff done first?
| { | ||
| "channelType": "LETTER", | ||
| "dailyCapacity": 500000, | ||
| "id": "supplier1", |
There was a problem hiding this comment.
Currently we use "TestSupplier1" for component tests https://github.com/NHSDigital/nhs-notify-supplier-api/blob/main/tests/config/global-setup.ts#L16 - so we might want to align this if this is to support testing?
There was a problem hiding this comment.
There's going to be another bit of work to migrate from the current suppliers table to thie new 'supplier-config' table when we'll do this
| @@ -34,13 +34,13 @@ resource "aws_dynamodb_table" "supplier-configuration" { | |||
| global_secondary_index { | |||
| name = "EntityTypeIndex" | |||
| hash_key = "entityType" | |||
There was a problem hiding this comment.
Will this GSI be used? There seems to be no logic or tests for it
There was a problem hiding this comment.
Not yet - but it will be
There was a problem hiding this comment.
I think you don't need a separate entity type index, as the PK already indexes on ENTITY#<entitytype>
There was a problem hiding this comment.
You could in fact make the primary PK/SK 'entityType' and 'id' fields, I think the DDB loader script adds these pk/sk fields redundantly, and could probably be dropped if you want?
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
from
dbe5f3e to
ce28417
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
from
ee81c02 to
8f124b7
Compare
3 participants
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.