Feature/cdapi 153 Add PR number to OAS#116
Draft
nhsd-rebecca-flynn wants to merge 2 commits intomainfrom
Draft
Conversation
nhsd-rebecca-flynn
force-pushed
the
feature/CDAPI-153
branch
from
f640c7d to
35adf7e
Compare
nhsd-rebecca-flynn
force-pushed
the
feature/CDAPI-153
branch
from
cc35e51 to
a7213d6
Compare
|
|
Deployment Complete
|
Collaborator
nhsd-jack-wainwright
left a comment
nhsd-jack-wainwright
left a comment
There was a problem hiding this comment.
LGTM 👍, just one question
| yq eval '.x-nhsd-apim.target.url = env(TARGET_URL) | .x-nhsd-apim.target.security.secret = env(MTLS_SECRET_NAME)' -i /tmp/proxy-specification.yaml | ||
|
|
||
| - name: Append PR number to API title | ||
| if: ${{ inputs.pr-number != '' }} |
Collaborator
There was a problem hiding this comment.
If pr-number is not defined here will it equate to an empty string?
Contributor
Author
There was a problem hiding this comment.
If the pr-number is not defined, this step (appending the pr number) will be skipped and the title will be as per the oas file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the PR number to the oas file if there is one.
Context
To make it easier to add PR based proxies in the developer portal
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.