Closed
Conversation
added 3 commits
April 24, 2026 12:20
…ctClassesCache into the RID manager. Update AddRequest to conditionally ensure objectSid based on object class names. Remove unused async cache for allowed object classes.
…sCache to streamline cache operations
added 2 commits
April 24, 2026 12:37
…he by removing redundant checks
…in ObjectSIDUseCase and integrate ObjectSidCacheRedisClient into TestProvider
milov-dmitriy
requested changes
Apr 24, 2026
Comment on lines
+41
to
+45
| async def compute() -> set[str]: | ||
| names = await self._object_class_dao.get_object_class_names_include_attribute_type("objectSid") | ||
| return {n.lower() for n in names} | ||
|
|
||
| return await self._objectsid_allowed_object_classes_cache.get_or_compute(compute) |
Collaborator
There was a problem hiding this comment.
давай async def compute унесем внутрь ObjectSidAllowedObjectClassesCache
думаю тут нет смысла держать эту функцию
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.