Attach release assets on tag; bump to 0.1.1#6
Merged
Conversation
Tags previously only published to PyPI and stored Actions artifacts, so the GitHub Release page had no assets. Add a github-release job that creates the release (with generated notes) and uploads all dist files, and set skip-existing on the PyPI publish so re-running a tag doesn't fail on files PyPI already has. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQbVkPEprK2ebcjck5ouUy
Patch release so the new github-release job can attach assets via a normal v0.1.1 tag instead of rewriting v0.1.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQbVkPEprK2ebcjck5ouUy
There was a problem hiding this comment.
Pull request overview
This PR enhances the release workflow so that version tag builds not only publish to PyPI and store artifacts, but also create/update a GitHub Release and attach the built distribution files as release assets.
Changes:
- Configure PyPI publishing to skip already-existing files to support safe re-runs/backfills of tags.
- Add a new tag-only
github-releasejob that downloads built artifacts and uploads them as GitHub Release assets with autogenerated release notes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+120
to
+123
| github-release: | ||
| name: attach assets to GitHub Release | ||
| needs: [build-wheels, build-sdist] | ||
| if: github.ref_type == 'tag' |
Moge800
changed the title
Per review: without the gate, a PyPI outage could leave a GitHub Release without a matching PyPI upload. Re-running the tag after a failure is safe because publish uses skip-existing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQbVkPEprK2ebcjck5ouUy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tag pushes published to PyPI and stored Actions artifacts, but never created a GitHub Release with assets — the v0.1.0 release page is empty.
github-releasejob (tag-only,contents: write) that creates the release with generated notes and attaches all dist files (3 wheels + sdist) viasoftprops/action-gh-release@v2.skip-existing: trueon the PyPI publish so re-running a tag never fails on files PyPI already has.pyproject.toml+__version__) so the assets ship via a normal patch release instead of rewriting the v0.1.0 tag.After merging
Tag
v0.1.1on the merge commit — the workflow publishes 0.1.1 to PyPI and creates the GitHub Release with all assets attached.🤖 Generated with Claude Code