🐛 Bugfix: Disable tool and skill selection when user is not in edit mode#3064
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent users from changing tool/skill selections when they are not in an editable agent context (e.g., no agent selected / not in create mode), by tightening read-only detection and ensuring the Tool management UI relies on the store-derived read-only state.
Changes:
- Update
isReadOnly()logic to treat “not creating + no current agent selected” as read-only. - Remove the
isReadOnlyprop wiring intoToolManagementand rely onuseAgentConfigStore().isReadOnly()directly. - Minor UI prop change to the Import button in the agent selector header.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/stores/agentConfigStore.ts | Updates read-only determination to cover the “no agent selected” state. |
| frontend/app/[locale]/agents/components/AgentSelectorHeader.tsx | Removes type="text" from the Import button. |
| frontend/app/[locale]/agents/components/AgentConfigComp.tsx | Stops passing isReadOnly into ToolManagement. |
| frontend/app/[locale]/agents/components/agentConfig/ToolManagement.tsx | Simplifies read-only handling to always use the store value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WMC001
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.