fix(conversation): open cached perps actions locally#6452
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves how trade-related app-card actions are handled in conversations by attempting to open Perps/Spot trade actions directly in local screens when the needed market/token data is already cached, falling back to the existing URL/web handling otherwise.
Changes:
- Add URL parsing helpers (
toPerpsTradeAction,toSpotTradeAction) to identify Perps vs Spot trade actions and extract parameters. - Update
ConversationFragmentto open Perps/Spot trade actions locally when cache prerequisites are met. - Add unit tests covering the new parsing behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/src/test/java/one/mixin/android/ui/conversation/PerpsTradeActionTest.kt | Adds JVM tests for Spot/Perps trade action parsing. |
| app/src/main/java/one/mixin/android/ui/conversation/PerpsTradeAction.kt | Introduces Perps/Spot action models and URL parsing utilities. |
| app/src/main/java/one/mixin/android/ui/conversation/ConversationViewModel.kt | Adds an IO-thread helper to query cached token data by asset id. |
| app/src/main/java/one/mixin/android/ui/conversation/ConversationFragment.kt | Attempts local navigation for cached trade actions before falling back to openAsUrlOrWeb. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.