feat(wallet): add opt-in ramps initialization configs#9290
Open
georgeweiler wants to merge 6 commits into
Open
feat(wallet): add opt-in ramps initialization configs#9290georgeweiler wants to merge 6 commits into
georgeweiler wants to merge 6 commits into
Conversation
georgeweiler
temporarily deployed
to
default-branch
GitHub Actions
Inactive
Export RampsService, RampsController, and TransakService wallet init configurations for clients that opt in, bumping @metamask/wallet to 4.1.0. Co-authored-by: Cursor <cursoragent@cursor.com>
georgeweiler
force-pushed
the
feat/wallet-ramps-init
branch
from
ff63aca to
5ad0e0f
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
- Remove rampsController/rampsService/transakService slots from
InstanceSpecificOptions — opt-in configs are self-contained and
should not leak into the default options surface
- Use indexed access into RampsControllerOptions for requestCacheTTL
and requestCacheMaxSize to stay coupled to the upstream type
- Document AuthenticationController:getBearerToken prerequisite on
the rampsService export so consumers know what must be registered
- Replace client-specific context strings ('extension', 'mobile-ios')
with 'test' in unit tests
- Add ramps instance directory to CODEOWNERS under money-movement
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Restore rampsController/rampsService/transakService slots in InstanceSpecificOptions — the InitializationConfiguration type derives options typing from this map, removing them makes options unknown throughout all three init functions - Add type casts (as never) for parent and actions in ramps messenger construction — ramps messenger types require parent actions (RampsService:*, TransakService:*, AuthenticationController:getBearerToken) not present in DefaultActions, since these are opt-in configs - Bump @metamask/ramps-controller dep from ^14.3.0 to ^15.0.0 to satisfy yarn constraints - Bump @metamask/wallet dep in wallet-cli from ^5.0.0 to ^5.1.0 - Bump root monorepo version from 1077.0.0 to 1078.0.0 - Add [5.1.0] CHANGELOG section with footer links Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Run readme-content:update to regenerate dependency graph after adding @metamask/ramps-controller to wallet's dependencies - Add PR link and dep bump entry to wallet [5.1.0] changelog section - Update wallet-cli changelog to reflect @metamask/wallet ^5.1.0 bump Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The test files are nested at ramps/<name>/ so the path to initialization/defaults.ts is ../../../defaults, not ../../defaults. Fixes lint:dependencies unresolved import failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@metamask/walletinitialization configs forRampsService,RampsController, andTransakServiceunder@metamask/wallet/initialization/instances/ramps.@metamask/walletto 4.1.0 and add@metamask/ramps-controlleras a dependency.@metamask/ramps-controllerpackage itself.Test plan
yarn workspace @metamask/wallet run jest --no-coverage --testPathPattern=ramps --watchman=falseyarn workspace @metamask/wallet run buildMade with Cursor