fix(transaction-controller): resimulate latest transaction data instead of stale captured data#9287
Draft
vinistevam wants to merge 2 commits into
Draft
fix(transaction-controller): resimulate latest transaction data instead of stale captured data#9287vinistevam wants to merge 2 commits into
vinistevam wants to merge 2 commits into
Conversation
…sure active transactions are correctly handled
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
ResimulateHelperre-simulates active unapproved transactions every 3 seconds. The timer's#startcaptured thetransactionMetain a closure and, because it returns early when a timer already exists for the id, never refreshed it. When a transaction was updated after resimulation began (e.g. editing a batch approval amount), the loop kept simulating the stale parameters, causing the simulation result to flicker between the old and new outcomes.#startnow takes atransactionIdand the timer reads the latest transaction from state on each tick (via a new#getResimulatableTransactionshelper), stopping itself if the transaction is gone or no longer active.References
Estimated changeskeeps pivoting its result fromTx likely to failto balance estimations every 1-2secs metamask-extension#43673Checklist