Skip to content

update suite_report to use cylc-run sources#224

Merged
Sam Clarke-Green (t00sa) merged 2 commits intoMetOffice:mainfrom
james-bruten-mo:use_extracted_source
Apr 16, 2026
Merged

update suite_report to use cylc-run sources#224
Sam Clarke-Green (t00sa) merged 2 commits intoMetOffice:mainfrom
james-bruten-mo:use_extracted_source

Conversation

@james-bruten-mo
Copy link
Copy Markdown
Collaborator

@james-bruten-mo James Bruten (james-bruten-mo) commented Apr 15, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Sam Clarke-Green (@t00sa)

This changes suite_report to use the source code extracted by the rose-stem suite when identifying branch information, rather than extracting it itself. This should prevent issues when a local clone is switched to a new branch during the run. I had thought the housekeeping tasks would need updating to avoid deleting these extracted clones, but it turns out none of the suites remove that.

This also corrects the log_file logic so that it defaults to the suite path, as was the original intention.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Tested using a random UM branch - output below:

Test Suite Results - um - um_test/run1

Suite Information

Item Value
Suite Name um_test/run1
Suite User james.bruten
Workflow Start 2026-04-15T10:14:33
Groups Run check_groups_coverage
Dependency Reference Main Like
casim MetOffice/casim@2026.03.1 True
jules MetOffice/jules@2026.03.1 True
moci MetOffice/moci@2026.03.1 True
mule MetOffice/mule@2026.03.1 True
shumlib MetOffice/shumlib@2026.03.1 True
socrates MetOffice/socrates@2026.03.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.1 True
ukca MetOffice/ukca@2026.03.1 True
um james-bruten-mo/um@um14.1_release False
um_aux MetOffice/um_aux@2026.03.1 True
um_meta MetOffice/um_meta@2026.03.1 True

Approvals

Code Owners

Section Owner Deputy State
rose_stem jamesbruten roddysharp Pending
top_level jenniferhickson samclarkegreen Pending
admin SSD Team -- Pending
stash roddysharp ericaneininger Pending
upgrade_macros ericaneininger jamesbruten Pending
bin SSD Team -- Pending

Config Owners

No UM Config Owners Required

Task Information

✅ succeeded tasks - 5

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

Copy link
Copy Markdown
Collaborator

@t00sa Sam Clarke-Green (t00sa) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and testing reports correct branch name.

@t00sa Sam Clarke-Green (t00sa) merged commit 8e347b5 into MetOffice:main Apr 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants