update suite_report to use cylc-run sources#224
Merged
Sam Clarke-Green (t00sa) merged 2 commits intoMetOffice:mainfrom Apr 16, 2026
Merged
update suite_report to use cylc-run sources#224Sam Clarke-Green (t00sa) merged 2 commits intoMetOffice:mainfrom
Sam Clarke-Green (t00sa) merged 2 commits intoMetOffice:mainfrom
Conversation
Sam Clarke-Green (t00sa)
approved these changes
Apr 15, 2026
Collaborator
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
Looks good and testing reports correct branch name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Sam Clarke-Green (@t00sa)
This changes suite_report to use the source code extracted by the rose-stem suite when identifying branch information, rather than extracting it itself. This should prevent issues when a local clone is switched to a new branch during the run. I had thought the housekeeping tasks would need updating to avoid deleting these extracted clones, but it turns out none of the suites remove that.
This also corrects the log_file logic so that it defaults to the suite path, as was the original intention.
Code Quality Checklist
Testing
Tested using a random UM branch - output below:
Test Suite Results - um - um_test/run1
Suite Information
Approvals
Code Owners
Config Owners
No UM Config Owners Required
Task Information
✅ succeeded tasks - 5
Security Considerations
AI Assistance and Attribution
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review