Test duplicateNonManifoldVertices on a vertex incident to two holes#6412
Merged
Conversation
Fedr
changed the title
Grantim
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for
duplicateNonManifoldVerticescovering a non-manifold vertex that joins two open triangle fans: two triangles{0,1,2}and{0,3,4}sharing only vertex #0, so four edges with origin at that vertex have a hole on one side (two with noleft(e)and two with noright(e)).The existing
duplicateNonManifoldVerticestest covers only two closed fans around the shared vertex; this adds the complementary hole-adjacent case, exercising the code path recently refactored in #6355 and #6405.The test verifies that exactly one duplication
#0 → #5is reported, and checks both triangles in full afterwards: the first found fan keeps the original vertex ({0,1,2}unchanged) while the other one is rewritten to{5,3,4}.