Skip to content

WIP fixed safe area rendering on iOS and cmake configuration for android#4472

Draft
gabriel-bolbotina wants to merge 1 commit intodev/qt-6.10.2from
fix-safearea-and-android-configuration
Draft

WIP fixed safe area rendering on iOS and cmake configuration for android#4472
gabriel-bolbotina wants to merge 1 commit intodev/qt-6.10.2from
fix-safearea-and-android-configuration

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

@gabriel-bolbotina gabriel-bolbotina commented Apr 24, 2026

Did the following:

  • Removed safe area platform-specific functions, relied on how Qt already calculates it
  • Used
  • Formatted code

UI:

ScreenRecording_04-24-2026.18-18-51_1.MP4

Remaining issues:

  • some elements using mmHighlight are not rendering the highlight at all or delayed. For example, there is a delayed rendering for Map sketches which are not in real time, only after finishing up the sketch and when selecting point features on the map. Lines seem to get the highlight.

TODOs:

  • Fix MMHighlight to render map sketches in real time and to highlight selected features on the map. currently it does not work
  • Patch the vcpkg android ports to properly configure and build the project
  • check if we should refactor how safe area is handled in QML components, we can keep it as it is, or maybe there is a better way to do it

Apply the api safearea to style property
Formatted code
Copy link
Copy Markdown
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :)

Comment thread app/main.cpp
Comment on lines +881 to +883
auto applyMargins = [style, quickWindow]()
{
const QMargins m = quickWindow->safeAreaMargins();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to read and store these if it is automatically handled by Qt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants