Open
Conversation
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Withalion
added
FROZEN 🥶
📦 Build Artifacts Ready
|
Contributor
|
Some visual and component changes:
|
This commit adds both UDP & TCP sockets under one network provider. We further differ external provider into bluetooth and network providers.
Modified the MMIconCheckBoxHorizontal to feature a description if needed Modularised the MMPositionProviderPage Refactored MMBluetoothConnectionDrawer to be used for the network provider as well Changes the connecting and failure images for the network provider Other small changes
gabriel-bolbotina
force-pushed
the
feature/network-provider
branch
from
c0e811a to
c415f60
Compare
Coverage Report for CI Build 25419530397Coverage decreased (-0.5%) to 57.438%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions240 previously-covered lines in 9 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Added ip address getter for network provider Changed provider constructor to make iOS device connect to external IP provider
📦 Build Artifacts Ready
|
Added hyperlink Modified the getIPAddress method Enhanced visuals
📦 Build Artifacts Ready
|
|
GPS Outstanding Issues & Recommnedations: iOS / Android:
2. External receiver connection details — IP address and port not displayed
3. External receiver settings — no option to edit after initial setup
iOS only 4. Manage GPS Receiver" button is cut off and inaccessible
|
fIxed gps data button alignment Corrected some QML warnings for the position kit
📦 Build Artifacts Ready
|
Contributor
|
Updated implementation to solve the second and fourth findings from the previous comment. New UI:
|
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Contributor
Author
|
I fixed some issues found with @IvaKuklica during testing.
Some more stuff that I noticed and should be fixed:
NOTE FOR TESTERS |
Withalion
commented
Apr 29, 2026
Contributor
Author
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
I'll review the rest tomorrow
Comment on lines
+108
to
+109
| height: Math.max( contentColumn.implicitHeight, | ||
| ListView.view.height - ( ListView.view.contentHeight - height ) ) |
Contributor
Author
There was a problem hiding this comment.
why do we need to specify the height now? isn't the list.footer placing the footer at the bottom anyway? as I understand it now the footer grows to fill the available height
Contributor
There was a problem hiding this comment.
Without this height calculation the footer is placed just under the list components, so it is depending on the list actual height, not the maximum one
Withalion
commented
Apr 30, 2026
Contributor
Author
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
The QML will need some more work, but besides that it looks nice 👍
Comment on lines
+88
to
+91
| list.footer: Item { | ||
| width: ListView.view.width | ||
| height: continueButton.height + __style.margin20 | ||
|
|
Contributor
Author
There was a problem hiding this comment.
It doesn't seem like we need the wrapper here
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Implemented code review findings
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1893
This PR adds new network position provider support. The user is able to connect both UDP and TCP providers.
New UI: