sdm: Generalise all applicable tests to BtrFS and Ext4 and different compressions#123
Open
MaxG87 wants to merge 8 commits into
Open
sdm: Generalise all applicable tests to BtrFS and Ext4 and different compressions#123MaxG87 wants to merge 8 commits into
MaxG87 wants to merge 8 commits into
Conversation
All tests are executed for both file system types, now. Where applicable, four different options of compression arguments are covered too, including `None` and not passing anything.
Where applicable, both file systems are tested for a given test implementation. Only mount_device is used to mount devices.
MaxG87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR changes all tests to work on both, BtrFS and ext4 fixtures. This ensures that all supported operations and all desired behaviours hold for both file systems.
Following the same spirit, many tests now are parametrised regarding the file system compression. This ensures that mounting a file system accepts None, various values and skipping passing the argument.
After all that, the file system specific functions are made private. Now the public interface consists of generic functions only.
Make filesystem-specific mount functions private
All tests are extended to cover both BtrFS and ext4 fixtures, ensuring that supported operations and desired behaviours hold for both file systems.
Tests are also parametrised over filesystem compression options, covering None, explicit values, and omitting the argument entirely.
With full test coverage in place, the filesystem-specific functions (mount_btrfs_device, mount_ext4_device) are made private. The public interface now consists of generic functions only.