Conditionally clean up mount directories based on OpenDirectory configuration#115
Open
Copilot wants to merge 5 commits into
Open
Conditionally clean up mount directories based on OpenDirectory configuration#115Copilot wants to merge 5 commits into
OpenDirectory configuration#115Copilot wants to merge 5 commits into
Conversation
Copilot created this pull request from a session on behalf of
MaxG87
May 30, 2026 20:09
View session
Copilot
AI
changed the title
Refactor device opening to config-driven mount root; remove
Conditionally clean up mount directories based on May 30, 2026
open destination argOpenDirectory configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open/closepreviously treated mount directory lifecycle inconsistently with configuration intent. This change aligns behavior so configured open paths are preserved, while temporary paths are removed after a successful close.Behavioral contract
OpenDirectoryis configured.OpenDirectoryis not configured andclosesucceeds.CLI close-path cleanup logic
close(...)via aremove_mount_dirsflag derived fromparsed_config.OpenDirectory is None.Test expectation updates
OpenDirectorymount dirs remain present