Skip to content

chore: release main#102

Open
MaxG87 wants to merge 1 commit into
mainfrom
release-please--branches--main
Open

chore: release main#102
MaxG87 wants to merge 1 commit into
mainfrom
release-please--branches--main

Conversation

@MaxG87

@MaxG87 MaxG87 commented Apr 23, 2026

Copy link
Copy Markdown
Owner

🤖 I have created a release beep boop

3.5.0

3.5.0 (2026-06-13)

Documentation

  • Add landing page README in 🇬🇧 and 🇩🇪 (8327cbc)

Miscellaneous Chores

3.5.0

3.5.0 (2026-06-13)

Miscellaneous Chores

3.5.0

3.5.0 (2026-06-13)

Miscellaneous Chores


This PR was generated with Release Please. See documentation.

@MaxG87 MaxG87 changed the title chore(main): release 3.7.0 chore(main): release 4.0.0 Apr 23, 2026
@MaxG87 MaxG87 force-pushed the release-please--branches--main branch 6 times, most recently from 7e2029b to 593c5cd Compare April 27, 2026 19:44
@MaxG87 MaxG87 force-pushed the release-please--branches--main branch 2 times, most recently from b218031 to db2d760 Compare May 8, 2026 07:11
@MaxG87 MaxG87 force-pushed the release-please--branches--main branch 3 times, most recently from 19b46a6 to 902a2dd Compare May 16, 2026 23:34
@MaxG87 MaxG87 force-pushed the release-please--branches--main branch 2 times, most recently from b7e63ba to 5115a20 Compare May 17, 2026 12:37
@prataffel

prataffel commented May 26, 2026

Copy link
Copy Markdown
Contributor

Hey,

This looks very cool -- especially the SudoPassCmd.

I don't know if the support for many different config file formats is, however, worth perusing -- this sounds to me like more overhead. I'd in any way prefer to have the file endings correspond to the file type. I see that this is not trivial -- you could have more than one file under ~/.config/butter-backup.<ending> and would need to rank them -- but maybe this just supports only using one type?
However, allowing comments is quite nice, I think; hence, I'd be in favor of toml or json5.

Might touching the config files, anyways, be an opportunity to merge exclude files with the configuration? ExcludePatternsFile is in there, already, and factoring them out might increase readability -- but one could introduce ExcludePattern, which would take a list of patterns.

@MaxG87

MaxG87 commented May 26, 2026

Copy link
Copy Markdown
Owner Author

Thank you very much for the remarks.

I was considering to make the ending match the file format but tried to avoid the effort. Maybe I'll give it a try, though. The support for so many formats isn't really a burden so far. Otherwise I wouldn't have added all of them. Lets see how that will develop if the file ending reflects the format.

I am not so optimistic regarding the ExcludePatterns option. My exclude patterns file is 67 lines long and grows occasionally. Duplicating it to every device configuration would bloat the configuration files. How many patterns would do you maintain?

@prataffel

prataffel commented May 27, 2026

Copy link
Copy Markdown
Contributor

I am not so optimistic regarding the ExcludePatterns option. My exclude patterns file is 67 lines long and grows occasionally. Duplicating it to every device configuration would bloat the configuration files. How many patterns would do you maintain?

That is true. I have 2 times ~30... 40 lines of excludes. With a nice config format, I could just fold them automatically, most of the time. But maybe such an addition would distract more than it would help.

How do you consider to allow a config file in ~/.config/butter-backup/config.<ending> (or whatever filename seems reasonable to you)? Such a directory could be a natural home for the exclude files (that is at least how it appears to me). But I think the current status is also very fine:).

@MaxG87

MaxG87 commented May 28, 2026

Copy link
Copy Markdown
Owner Author

I have thought about this.

I really like to move the configuration into a dedicated folder. A major release is the correct opportunity to do so.

I will not add an ExcludePattern list to the configuration. I see only three ways to implement it:

  1. Write it to a temporary file: This would make the execution more brittle and require handling a long-lived context.
  2. Reimplement file selection manually and be aware whether restic or rsync needs to be mimicked. This is way to complex and will not happen.
  3. Pass over all elements of the list to the command line of restic or rsync at once. This is super dangerous, as it could lead to a too long argument list, making the backup program crash. I am not looking forward to getting that issue under control.

With a new config folder, I think most of the issues of an exclude patterns file will be addressed.

@MaxG87 MaxG87 force-pushed the release-please--branches--main branch 2 times, most recently from 05686c1 to 8926c6a Compare May 31, 2026 20:29
@MaxG87 MaxG87 changed the title chore(main): release 4.0.0 chore: release main Jun 9, 2026
@MaxG87 MaxG87 force-pushed the release-please--branches--main branch from 8926c6a to 363c613 Compare June 9, 2026 18:43
@MaxG87 MaxG87 force-pushed the release-please--branches--main branch from 363c613 to 53b39cb Compare June 13, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants