feat: navigation scope filter for TA with manage-submissions by YheChen · Pull Request #8046 · MarkUsProject/Markus

YheChen · 2026-07-06T22:54:42Z

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Ref #6424

This PR adds a navigation-scope filter for TAs who have the manage submissions permission.

Previously, result-page navigation for TAs was scoped to their assigned submissions. With this change, TAs who can manage submissions can choose whether result navigation should include:

only submissions assigned to them
all submissions for the assignment

The new option appears in the result filter modal as “Only assigned submissions” under “Navigation Scope”. It is shown only to TAs with manage-submissions permission. TAs without that permission remain restricted to assigned submissions, and instructors are unaffected.

This PR also:

exposes can_manage_submissions in result JSON data
persists and normalizes the new filter option in local storage
updates grouping navigation/filtering logic to respect the new scope
adds frontend, controller, and model tests for the new behavior

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)	x
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)	x
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

I have performed a self-review of my changes.
- Check that all changed files included in this pull request are intentional changes.
- Check that all changes are relevant to the purpose of this pull request, as described above.
I have added tests for my changes, if applicable.
- This is required for all bug fixes and new features.
I have updated the project documentation, if applicable.
- This is required for new features.
If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

I have updated the project Changelog (this is required for all changes).
I have verified that the pre-commit.ci checks have passed.
I have verified that the CI tests have passed.
I have reviewed the test coverage changes reported by Coveralls.
I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

coveralls · 2026-07-06T23:08:17Z

Coverage Report for CI Build 28990118433

Coverage increased (+0.01%) to 90.299%

Details

Coverage increased (+0.01%) from the base build.
Patch coverage: 75 of 75 lines across 6 files are fully covered (100%).
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	51091
Covered Lines:	47147
Line Coverage:	92.28%
Relevant Branches:	2450
Covered Branches:	1200
Branch Coverage:	48.98%
Branches in Coverage %:	Yes
Coverage Strength:	127.34 hits per line

💛 - Coveralls

david-yz-liu

@YheChen nice work, I left a few comments. Also modify the PR description to replace "Closes" with "Ref". This PR alone does not close the issue, as there's two parts involved.

david-yz-liu · 2026-07-08T18:29:42Z

-    if (!this.state.prefetchedIds || this.shouldRefetchIds()) {
-      this.fetchGroupingIds();
-    }
+    this.refreshFilterData(() => {


Revert this change, it is not related to this PR

david-yz-liu · 2026-07-08T18:31:53Z

    }
  };

+  normalizeFilterData = filterData => {


Revert this change; it's unrelated to this PR

david-yz-liu · 2026-07-08T18:34:30Z

+    results
+  end
+
+  def filter_to_assigned_groupings?(current_role, filter_data)


inline this function. You can also modify the logic to use an allowed_to? with :manage_submissions

david-yz-liu · 2026-07-08T18:35:01Z

 ### 🚨 Breaking changes

 ### ✨ New features and improvements
+- Added a submissions table toggle that lets TAs with manage submissions permission view all submissions or only assigned submissions (#8047)


This changelog entry is incorrect

david-yz-liu · 2026-07-08T18:35:09Z

    new webpack.ProvidePlugin({
      $: "jquery",
      jQuery: "jquery",
+      React: "react",


Revert this change

david-yz-liu · 2026-07-08T18:39:46Z

      add_criterion: Add Criterion Filter
+      assigned_submissions_only: Only assigned submissions
      invalid_range: Invalid Range
+      navigation_scope: Navigation Scope


Rename this to "Submission Scope" (I don't think "Navigation" is helpful here, as the entire filter modal is about modifying navigation)

david-yz-liu · 2026-07-08T18:41:30Z

+      <div className={"filter"} data-testid={"assigned-graders-only"}>
+        <p>{I18n.t("results.filters.navigation_scope")}</p>
+        <div className={"assigned-graders-only-toggle"}>
+          <input


Rather than have a checkbox, I'd like to see to radio buttons with labels "My assigned submissions" and "All submissions".

…ults

YheChen added 3 commits July 4, 2026 19:31

added Navigation Scope checkbox for Tas who have managesubmissions

07641bc

added Navigation Scope checkbox for Tas who have managesubmissions

45a2163

fixed test failing

62e4edc

YheChen changed the title ~~WIP: feat: toggle filter manage submissions~~ WIP: feat: navigation scope filter for manage-submissions TA Jul 6, 2026

YheChen changed the title ~~WIP: feat: navigation scope filter for manage-submissions TA~~ WIP: feat: navigation scope filter for TA with manage-submissions Jul 6, 2026

YheChen added 2 commits July 6, 2026 19:10

changelog

c3db2a5

Merge branch 'master' into feat/toggle-filter-manage-submissions

0a70a7b

YheChen mentioned this pull request Jul 6, 2026

docs: navigation scope filter for TA with manage-submissions MarkUsProject/Wiki#269

Closed

YheChen added 2 commits July 6, 2026 19:30

fixed flaky test

eec3233

react not defined in webpack

42aa494

YheChen changed the title ~~WIP: feat: navigation scope filter for TA with manage-submissions~~ feat: navigation scope filter for TA with manage-submissions Jul 7, 2026

add padding between checkbox and label in modal

15f28cc

YheChen requested a review from david-yz-liu July 7, 2026 03:32

david-yz-liu reviewed Jul 8, 2026

View reviewed changes

YheChen added 8 commits July 8, 2026 18:35

Update docs for navigation scope filter

b675873

Address review comments on navigation filter

b6afdcb

Rename submission scope filter label

7c2567f

Use radio buttons for submission scope

9bd73c4

refactored to inline filter_to_assigned_groupings into navigation res…

d927ef0

…ults

Merge branch 'master' into feat/toggle-filter-manage-submissions

03c0d48

updated changelog to be more clear, and have correct PR number

afaa49b

removed period from changelog to maintain consistency

4586669

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: navigation scope filter for TA with manage-submissions#8046

feat: navigation scope filter for TA with manage-submissions#8046
YheChen wants to merge 16 commits into
MarkUsProject:masterfrom
YheChen:feat/toggle-filter-manage-submissions

YheChen commented Jul 6, 2026 •

edited

Loading

Uh oh!

coveralls commented Jul 6, 2026 •

edited

Loading

Uh oh!

david-yz-liu left a comment

Uh oh!

david-yz-liu Jul 8, 2026

Uh oh!

david-yz-liu Jul 8, 2026

Uh oh!

david-yz-liu Jul 8, 2026

Uh oh!

david-yz-liu Jul 8, 2026

Uh oh!

david-yz-liu Jul 8, 2026

Uh oh!

david-yz-liu Jul 8, 2026

Uh oh!

david-yz-liu Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

YheChen commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Type of Change

Checklist

Questions and Comments

Uh oh!

coveralls commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 28990118433

Coverage increased (+0.01%) to 90.299%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

david-yz-liu Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YheChen commented Jul 6, 2026 •

edited

Loading

coveralls commented Jul 6, 2026 •

edited

Loading