MDEV-39347: Referred databases are not present in the context#4951
Merged
bsrikanth-mariadb merged 1 commit intobb-12.3-MDEV-38805-dev-sprint-work-2from Apr 24, 2026
Conversation
bsrikanth-mariadb
force-pushed
the
12.3-MDEV-39347-referred-db-create-stmt-not-written-to-ctx
branch
from
3529117 to
2366ead
Compare
spetrunia
reviewed
Apr 24, 2026
| 1 OOM error | ||
| */ | ||
| static bool store_db_ddl(THD *thd, HASH *db_name_hash, String &sql_script, | ||
| const char *db_name, bool req_use_db_stmt= false) |
Member
There was a problem hiding this comment.
bool req_use_db_stmt= false ... There are only two uses of the function. Please make the parameter non- optional.
spetrunia
approved these changes
Apr 24, 2026
Member
spetrunia
left a comment
spetrunia
left a comment
There was a problem hiding this comment.
Ok to push after the above is addressed.
Currently, only create/use DDLs for the database that is in the current thread is stored in the context. However, we do store CREATE DDL statements of other database tables in the context, if they are referred by the query. So, while replaying the context, if the other database is not present in the system, then we get an error. == SOLUTION == Store CREATE DATABASE DDLs of the databases to the context, if any of those database tables are referred by the original query.
bsrikanth-mariadb
force-pushed
the
12.3-MDEV-39347-referred-db-create-stmt-not-written-to-ctx
branch
from
2366ead to
8cc3cfb
Compare
bsrikanth-mariadb
merged commit 8cc3cfb
into
bb-12.3-MDEV-38805-dev-sprint-work-2
12 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only create/use DDLs for the database that is in the current thread is stored in the context.
However, we do store CREATE DDL statements of other database tables in the context, if they are referred by the query. So, while replaying the context, if the other database is not present in the system, then we get an error.
== SOLUTION ==
Store CREATE DATABASE DDLs of the databases to the context, if any of those database tables are referred by the original query.