feat(alerts): fix #122 by implementing alert acknowledgement system#196
Merged
mijinummi merged 5 commits intoJun 22, 2026
Merged
Conversation
- Generate initial Prisma migration - Relocate and fix prisma.config.ts to support Prisma 7 Migrate dev/status - Correct step order in db-migration CI to deploy before checking status
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #122
This pull request implements the Alert Acknowledgement System to resolve issue #122.
Previously, there was no way for the security team to distinguish between unreviewed alerts and those that had been investigated. This caused potential overlap in work and confusion.
With this change, the
Alertmodel now tracksacknowledgedAtandacknowledgedBy. AnAcknowledgementsModuleprovides a new REST endpoint (POST /alerts/:id/acknowledge) allowing reviewers to explicitly mark alerts as acknowledged. To maintain data integrity and compliance, acknowledging an alert automatically appends anALERT_ACKNOWLEDGEDaction to the system'sAuditLogwithin a single atomic database transaction.4. Changes Made
schema.prismato includeacknowledgedAtandacknowledgedByon theAlertmodel.@nestjs/commonand@nestjs/coreto package dependencies to resolve project-wide TS compilation issues.AlertsModuleandAcknowledgementsModulefollowing the NestJS module architecture.AcknowledgementsControllerwith aPOST /alerts/:id/acknowledgeendpoint.AcknowledgementsServiceto handle the atomic acknowledgement and audit logging via Prisma$transaction.AcknowledgeAlertDtoto capturereviewerIdandreviewerName.AlertsModuleintoapp.module.ts.5. Testing
npm run build:backendto ensure strict TypeScript compilation passes without errors.pnpm dlx prisma generateand verified that schema changes were accurately reflected.$transactionwrapper used for DB operations).