Skip to content

feat: add retry logic and test coverage to splunksiemprovider#178

Open
Hassanjubril18 wants to merge 1 commit into
MD-Creative-Production:mainfrom
Hassanjubril18:feature/splunk-retry-and-tests
Open

feat: add retry logic and test coverage to splunksiemprovider#178
Hassanjubril18 wants to merge 1 commit into
MD-Creative-Production:mainfrom
Hassanjubril18:feature/splunk-retry-and-tests

Conversation

@Hassanjubril18

Copy link
Copy Markdown

Closes #133

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Related Issues

Fixes #
Related to #

Changes Made

Testing

  • I have tested these changes locally
  • Tests pass locally (npm run test)
  • Linting passes (npm run lint)
  • Code is formatted (npm run format)
  • TypeScript builds successfully (npm run build)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests passed with my changes

Screenshots (if applicable)

Additional Context

@mijinummi

Copy link
Copy Markdown
Collaborator

Hi @Hassanjubril18 , thanks for your contribution, please kindly fix the remaining 1 error, you pull from main and fix then push back. Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Splunk Integration

2 participants