feat(config): app-side mempool max-txs parity + migration repair#172
Merged
Conversation
PR #166 migrated precompiles/solidity to Hardhat 3, which requires Node.js >= 20 (engines.node in package.json) and switches the package to ESM. The README Quick Start stated no Node requirement, so a developer on Node 18 would hit a hard failure at npm install / hardhat run. Add an explicit prerequisite note. The npm scripts (compile/deploy:devnet/interact:devnet) kept their names across the migration, so the rest of the README's commands remain accurate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Aligns the app-side EVM mempool capacity across environments and makes the v1.20.0 config migration repair it on upgraded nodes: - Default `mempool.max-txs` raised 5000 -> 10000 for fresh configs (cmd/lumera/cmd/config.go). Mainnet runs the higher cap; devnet keeps 5000. - config migration (cmd/lumera/cmd/config_migrate.go): `mempool.max-txs` is now a force-set EVM-migrated key, and a disabled/legacy value (< 0, e.g. an upgraded pre-EVM home where the app-side mempool was off) is repaired to `migratedMempoolMaxTxs(chain-id)` — 5000 for devnet (lcfg.IsDevnetChainID), 10000 otherwise. This prevents an upgraded mainnet node from silently keeping the app-side mempool disabled (which would bypass EVM mempool admission, including the evmigration zero-signer path). Tests: - config_migrate_test.go / config_test.go: cover the new default, the disabled-value repair, and devnet vs mainnet selection. - New real-node integration test TestEVMigrationZeroSignerTxBroadcastSyncAfterLegacyMainnetConfigMigration: starts from a legacy pre-EVM app.toml (max-txs = -1), asserts migration writes max-txs = 10000 + EVM mempool defaults, then broadcasts a zero-signer migration tx successfully. Added evmtest.WriteLegacyPreEVMAppToml helper and updated the genesis-defaults assertion (5000 -> 10000). Docs: node-evm-config-guide, app-changes, roadmap, integration-mempool, unit-app-wiring, evmigration devnet-tests, devnet upgrade-testing, CHANGELOG updated for the new defaults and migration behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0115952322
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a-ok123
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the app-side EVM mempool capacity across environments and makes the v1.20.0 config migration repair it on upgraded nodes, so an upgraded mainnet node can't silently keep the app-side mempool disabled (which would bypass EVM mempool admission, including the evmigration zero-signer path).
Changes
Default capacity
mempool.max-txsdefault raised 5000 → 10000 for fresh configs (cmd/lumera/cmd/config.go). Mainnet runs the higher cap; devnet keeps 5000.Config migration (
cmd/lumera/cmd/config_migrate.go)mempool.max-txsis now a force-set EVM-migrated key.< 0— e.g. an upgraded pre-EVM home where the app-side mempool was off) is repaired tomigratedMempoolMaxTxs(chain-id): 5000 for devnet (lcfg.IsDevnetChainID), 10000 otherwise.Tests
config_migrate_test.go/config_test.go: new default, disabled-value repair, devnet vs mainnet selection.TestEVMigrationZeroSignerTxBroadcastSyncAfterLegacyMainnetConfigMigration: starts from a legacy pre-EVMapp.toml(max-txs = -1), asserts migration writesmax-txs = 10000+ EVM mempool defaults, then broadcasts a zero-signer migration tx successfully.evmtest.WriteLegacyPreEVMAppTomlhelper; updated the genesis-defaults assertion (5000 → 10000).Docs
node-evm-config-guide,app-changes,roadmap,integration-mempool,unit-app-wiring, evmigrationdevnet-tests, devnetupgrade-testing, andCHANGELOGupdated for the new defaults and migration behavior.Verification
go test ./cmd/lumera/cmd/— passgo build ./...,golangci-lint run ./cmd/lumera/...— 0 issuesgo vet -tags='integration test'on the mempool + evmtest packages — cleanNote
This branch has
mastermerged in (it includes the just-merged Hardhat 3 work from #166). It also carries one incidental docs commit — a Node ≥ 20 prerequisite note on theprecompiles/solidityREADME, follow-up to the #166 HH3 migration.🤖 Generated with Claude Code