Migrate ExitCriteria parameters to Ensemble.run()#1747
Open
jlnav wants to merge 6 commits into
Open
Conversation
…sim_max=30). merge ExitCriteria and .run parameters if both exist. Display associated deprecation warnings
… to prevent state between .runs().
…eps_with_deprecate_exitcriteria
…lways send data packet using persis_in even if its not set
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/deprecate_some_allocs #1747 +/- ##
=================================================================
Coverage ? 76.95%
=================================================================
Files ? 81
Lines ? 8405
Branches ? 1290
=================================================================
Hits ? 6468
Misses ? 1690
Partials ? 247 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensemble.run()has already been an empty function. Passing in subsets, steps, num sims, num gens, etc. into.run()is (I think) sensible since this resembles Xopt's.step(n_points). It makes the parameters of exit criteria a description of the run instead of a description of the entire ensemble.So
ensemble.run(sim_max=2000, wallclock_max=300)is possible. Deprecates ExitCriteria. So now we save an import, a class instantiation, and a parameter for Ensemble