Move currentKeyboardScript into SettingsValues and simplify InputLogic methods#106
Conversation
Moved the redundant `currentKeyboardScript` argument from multiple methods in `InputLogic.java` into the `SettingsValues` class. This simplifies method signatures and follows the existing TODO in the codebase. Updated all call sites across the project to match the new signatures. Key changes: - Added `mCurrentKeyboardScript` to `SettingsValues`. - Updated `Settings.loadSettings` and `SettingsValues` constructor to accept and store the script. - Refactored `InputLogic` methods: `onPickSuggestionManually`, `onCodeInput`, `getWordAtCursor`, `unlearnWordBeingDeleted`, and `restartSuggestionsOnWordTouchedByCursor`. - Updated all callers to provide the script when loading settings and remove it from refactored method calls. - Verified successful compilation of the project.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
The refactoring successfully moves the
currentKeyboardScriptargument from several methods inInputLogic.javainto theSettingsValuesclass, addressing a TODO and reducing redundancy in the codebase. All call sites have been updated and compilation has been verified.PR created automatically by Jules for task 1215721178354382085 started by @LeanBitLab