feat(sonos): add experimental local playback targets#391
Draft
mrzhbr wants to merge 6 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sonos:<UUID>and route local transport, seek, volume, metadata, CLI, and playbar behavior through a dedicated Sonos backendHardware validation
Validated on standalone S1 and S2 rooms, including multiple-room selection:
Grouped-room coordinator behavior is covered by mock integration tests but could not be hardware-tested. Sonos queue viewing and Sonos shuffle/repeat remain intentionally unsupported.
Verification
cargo fmt --all --checkcargo clippy --no-default-features --features telemetry -- -D warningscargo test --no-default-features --features telemetry— 519 passedcargo clippy -- -D warningscargo test— 738 passedcargo clippy --features all-sources -- -D warningsRelated to #251.