Remove global npm upgrade from deploy-nodejs/deploy-wasm jobs#676
Merged
Conversation
The 'npm install -g npm@latest' step causes MODULE_NOT_FOUND errors for the 'sigstore' module needed by --provenance during npm publish. This is a known issue where npm 11's in-place global upgrade on GitHub hosted runners fails to properly lay down its restructured dependency tree (sigstore is missing from node_modules). The bundled npm 10.9.x in both Node 20 and Node 22 already supports --provenance (added in npm 9.5.0), so the upgrade is unnecessary.
The wasm build does not define CPPHTTPLIB_OPENSSL_SUPPORT because OpenSSL is not available for Emscripten, causing set_ca_cert_path to be absent from the httplib Client interface. Wrap the call in a preprocessor guard; on wasm, CA cert configuration is skipped, which is fine since wasm's HTTP client path cannot use OpenSSL certificates.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'npm install -g npm@latest' step causes MODULE_NOT_FOUND errors for the 'sigstore' module needed by --provenance during npm publish. This is a known issue where npm 11's in-place global upgrade on GitHub hosted runners fails to properly lay down its restructured dependency tree (sigstore is missing from node_modules).
The bundled npm 10.9.x in both Node 20 and Node 22 already supports --provenance (added in npm 9.5.0), so the upgrade is unnecessary.