pandas: handle non-contiguous memory#42
Merged
Merged
Conversation
Use the numpy backend to ensure all numpy arrays extracted from pandas columns are C-contiguous before scanning. Non-contiguous arrays can arise from DataFrames backed by views into larger 2D arrays (e.g. pd.DataFrame(arr2d), transpose, concat, slicing). Previously the scan used memcpy with sizeof(T) stride which reads wrong data on non-contiguous layouts.
- Honour GEN env var (default to Ninja) - Wipe stale build directory on generator mismatch - Only clean build when BUILD_CLEAN=1 - Use ccache when available - Honour CMAKE_BUILD_PARALLEL_LEVEL / PARALLEL for parallelism - Handle artifact location flexibility
adsharma
force-pushed
the
use_arrow_scan_for_pandas
branch
from
6f46106 to
2dde501
Compare
adsharma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: LadybugDB/ladybug#647