fix: memory corruption due to accessing out of bounds output vector index#39
Closed
adsharma wants to merge 1 commit into
Closed
fix: memory corruption due to accessing out of bounds output vector index#39adsharma wants to merge 1 commit into
adsharma wants to merge 1 commit into
Conversation
…ndex In numpy_scan.cpp, the OBJECT/STRING scan path uses pos = i + offset (the absolute row index in the source array) as the output vector index for setNull() when handling None or NaN values: ```cpp // BEFORE (buggy): outputVector->setNull(pos, true /* isNull */); // pos = i + offset ``` The output vector is sized for DEFAULT_VECTOR_CAPACITY (= 2048) entries and expects 0-based indices within each batch. But pos is the absolute dataframe row index. When the COPY spans multiple batches (i.e., when offset >= DEFAULT_VECTOR_CAPACITY), pos exceeds the null mask buffer, causing a heap buffer overrun → the segfault / free(): invalid next size / munmap_chunk(): invalid pointer crashes seen on Linux.
Contributor
Author
|
Folded into #38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: LadybugDB/ladybug#672
In numpy_scan.cpp, the OBJECT/STRING scan path uses pos = i +
offset (the absolute row index in the source array) as the output
vector index for setNull() when handling None or NaN values:
The output vector is sized for DEFAULT_VECTOR_CAPACITY (= 2048)
entries and expects 0-based indices within each batch. But pos is
the absolute dataframe row index. When the COPY spans multiple
batches (i.e., when offset >= DEFAULT_VECTOR_CAPACITY), pos exceeds
the null mask buffer, causing a heap buffer overrun → the segfault
/ free(): invalid next size / munmap_chunk(): invalid pointer
crashes seen on Linux.