Fix test grouping on TeamCity for Gradle 9.3#2973
Open
labkey-tchad wants to merge 4 commits intorelease26.3-SNAPSHOTfrom
Open
Fix test grouping on TeamCity for Gradle 9.3#2973labkey-tchad wants to merge 4 commits intorelease26.3-SNAPSHOTfrom
labkey-tchad wants to merge 4 commits intorelease26.3-SNAPSHOTfrom
Conversation
Contributor
|
Hooray. |
labkey-danield
approved these changes
May 1, 2026
| return null; | ||
| } | ||
|
|
||
| private static void flattenSuiteInto(TestSuite destination, TestSuite source) |
Contributor
There was a problem hiding this comment.
Nit: Why not just flattenSuite ? The unanswered 'Into' is strange.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
In Gradle 9.3, they changed how it reports test results.
Test names within nested test suites (such as the one built by
JUnitTest) now include a bunch of summary information. This information (specifically the test count) varies between different suites and will vary over time as we add or remove tests. Having consistent test names is important for tracking test responsibility across different suites and tracking results over time.e.g.
instead of:
Flattening the nested test suites when running on TeamCity reverts to the old test names.
Related Pull Requests
Changes
Runner.flattenSuiteInto)