Skip to content

FIx for failed dragFill tests #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DariaBod merged 10 commits into from
Apr 30, 2026
Merged

FIx for failed dragFill tests #2971

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a50f13
fix testDragFillReadOnlyColumn()
DariaBod Apr 28, 2026
0cf0c7b
Merge branch 'develop' into fb_fixDragFillGrid
DariaBod Apr 28, 2026
73c70dc
update retry
DariaBod Apr 28, 2026
0bd2526
fix comment
DariaBod Apr 29, 2026
46cbed1
fix for MultiValueTextChoiceSampleTypeTest.testCrossFolderMVTCtoTCCon…
DariaBod Apr 29, 2026
6501401
Merge branch 'develop' into fb_fixDragFillGrid
DariaBod Apr 29, 2026
c60a59c
revert to the original method
DariaBod Apr 30, 2026
91d57ad
Merge branch 'develop' into fb_fixDragFillGrid
DariaBod Apr 30, 2026
8dba511
doc
DariaBod Apr 30, 2026
978143a
fix
DariaBod Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/org/labkey/test/components/ui/grids/EditableGrid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,14 +1055,9 @@ public void dragFill(WebElement startCell, WebElement endCell)
{
dismissPopover();
Locator.XPathLocator selectionHandleLoc = Locator.byClass("cell-selection-handle");
// Get the value from the start cell
String fillValue = getCellValue(startCell);
WebElement selectionHandle = selectionHandleLoc.waitForElement(getComponentElement(), 2_000);
WebElement selectionHandle = selectionHandleLoc.findElement(startCell);
dragToCell(selectionHandle, endCell);
// Handle appearing in endCell alone is insufficient — the selection can expand
// (handle moves) without fill values being applied. Wait for the actual value.
WebDriverWrapper.waitFor(() -> fillValue.equals(getCellValue(endCell)),
"Drag fill did not populate end cell with value: " + fillValue, 5_000);
selectionHandleLoc.waitForElement(endCell, 5_000);
}

public void selectCellRange(WebElement startCell, WebElement endCell)
Expand Down
Loading