Consolidate Dataclass data update methods - use DIB for update only

[XingY]

Rationale

This PR consolidates DataClass data update operations to use the DataIteratorBuilder (DIB) pipeline exclusively — the same approach already used for SampleType updates.

Related Pull Requests

• Remove altUpdateKeys from QueryInfo labkey-ui-components#1988
• Consolidate Dataclass data update methods - use DIB for update only #7483
• https://github.com/LabKey/limsModules/pull/2034
• https://github.com/LabKey/premiumModules/pull/541
• Drop LSID from provisioned dataclass tables testAutomation#2965

Changes

• DataClass updates now go through the DIB pipeline exclusively.
• LSID is rejected as a standalone update key with clear error messages.
• The provisioned table lsid column is dropped via deferred upgrade.
• Partition-based DIB logic is extracted and shared.
• getAltKeysForUpdate is removed from the interface and API.

[Copilot]

Pull request overview

This PR consolidates DataClass and Sample update behavior around DataIteratorBuilder (DIB)-based updates, removing LSID as an update/merge key and cleaning up deprecated DataClass storage by dropping the provisioned lsid column via a module upgrade.

Changes:

• Remove LSID-as-key support for sample/data update & merge; enforce RowId or Name-based keys and ignore LSID when provided alongside valid keys.
• Introduce shared updateRowsUsingPartitionedDIB() logic in AbstractQueryUpdateService and route Sample/DataClass updates through it.
• Remove provisioned DataClass lsid column (domain kind + upgrade code + DB scripts) and update integration tests accordingly.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
experiment/src/org/labkey/experiment/samples/AbstractExpFolderImporter.java	Stops setting the removed UseLsidForUpdate option during TSV import.
experiment/src/org/labkey/experiment/api/SampleTypeUpdateServiceDI.java	Routes updates through partitioned DIB; removes LSID-key paths and legacy update methods.
experiment/src/org/labkey/experiment/api/ExpDataImpl.java	Selects DataClass provisioned properties by RowId (not LSID) to support dropped provisioned LSID column.
experiment/src/org/labkey/experiment/api/ExpDataClassDataTableImpl.java	Enforces RowId/Name keys, blocks LSID-only keying, blocks RowId in merge (behind feature), and uses partitioned DIB updates.
experiment/src/org/labkey/experiment/api/DataClassDomainKind.java	Removes lsid from provisioned DataClass base properties, indexes, and FKs.
experiment/src/org/labkey/experiment/ExperimentUpgradeCode.java	Adds deferred upgrade to drop provisioned DataClass lsid column (and related indices).
experiment/src/org/labkey/experiment/ExperimentModule.java	Bumps schema version to 26.005 and centralizes experimental flag constant usage.
experiment/src/org/labkey/experiment/ExpDataIterators.java	Updates derivation/update logic to use RowId/Name instead of LSID-for-update config; removes LSID update config usage.
experiment/src/client/test/integration/DataClassCrud.ispec.ts	Expands integration coverage for keying behavior (RowId/Name/LSID) and partitioned-duplicate detection.
experiment/resources/schemas/dbscripts/sqlserver/exp-26.004-26.005.sql	Executes Java upgrade to drop provisioned DataClass lsid column (SQL Server).
experiment/resources/schemas/dbscripts/postgresql/exp-26.004-26.005.sql	Executes Java upgrade to drop provisioned DataClass lsid column (PostgreSQL).
api/src/org/labkey/api/query/DefaultQueryUpdateService.java	Removes conversion-table hook and always uses getDbTable() for convertTypes() entrypoint.
api/src/org/labkey/api/query/AbstractQueryUpdateService.java	Adds updateRowsUsingPartitionedDIB() and small null-iterator safety in _pump().
api/src/org/labkey/api/exp/query/ExpDataTable.java	Reorders enum constants (no functional behavior change expected).
api/src/org/labkey/api/exp/api/ExperimentService.java	Removes UseLsidForUpdate query option; adds shared experimental feature constant.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[labkey-adam]

@XingY there's an exp-26.004-26.005.sql script in 26.3 that should be merged to develop shortly.

[XingY]

@XingY there's an exp-26.004-26.005.sql script in 26.3 that should be merged to develop shortly.

OK. Thanks for the heads-up.