Drop redundant indices#196
Merged
labkey-adam merged 3 commits intodevelopfrom May 1, 2026
Merged
Conversation
labkey-jeckels
approved these changes
May 1, 2026
| DROP INDEX oconnor.experiment_db_experiment_number_key; | ||
| -- Converting experiment_db_experiment_number_created_createdby_description_t [experiment_number, created, createdby, description, type, parents, workbook, container, modifiedby, modified, comments] from unique to non-unique index because pk_experiment_db [experiment_number] overlaps it with a smaller column set | ||
| DROP INDEX oconnor.experiment_db_experiment_number_created_createdby_description_t; | ||
| CREATE INDEX experiment_db_experiment_number_created_createdby_description_t ON oconnor.experiment_db(experiment_number, created, createdby, description, type, parents, workbook, container, modifiedby, modified, comments); |
Contributor
There was a problem hiding this comment.
This is clearly not right. Let's not recreate it.
Suggested change
| CREATE INDEX experiment_db_experiment_number_created_createdby_description_t ON oconnor.experiment_db(experiment_number, created, createdby, description, type, parents, workbook, container, modifiedby, modified, comments); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Redundant indices waste disk space and degrade insert/update/delete performance
Related Pull Requests