SUP-1886-update veracode retry on 504#614
Open
effany wants to merge 10 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 35.56% 37.18% +1.61%
==========================================
Files 128 128
Lines 8463 8469 +6
==========================================
+ Hits 3010 3149 +139
+ Misses 5453 5320 -133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Add comprehensive unit tests for VeracodeAV::Client - Add comprehensive unit tests for Veracode::Client - Test HTTP requests, error handling, and authentication - Improve patch coverage from 62.50% to meet project standards - Use webmock for HTTP request stubbing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ababhis2
reviewed
Jun 15, 2026
| next_page = url | ||
| until next_page.nil? | ||
| response = http_get(next_page, {}, hmac_client: self) | ||
| response = http_get(next_page, {}, MAX_RETRIES_504_ONLY, true, hmac_client: self, retry_options: RETRY_OPTIONS_504_ONLY) |
There was a problem hiding this comment.
can you please elaborate what this is going to do?
504 was already part of the http.rb retry options. how does this all work
The way I am reading this is now instead of retrying 5 times we will be retrying 2 times. is that true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Veracode retry handling for 504 Gateway Timeout responses.
When a request to Veracode returns HTTP 504, the connector now retries the request up to 2 times, with a fixed 30-second interval between attempts.
This change improves resiliency against temporary Veracode-side timeouts while keeping retry behavior controlled and predictable.
https://kennasecurity.atlassian.net/jira/software/c/projects/SUP/boards/58?selectedIssue=SUP-1886