Unify encoding and decoding key APIs#515
Open
arckoor wants to merge 1 commit into
Open
Conversation
arckoor
force-pushed
the
raw-key-api-rework
branch
from
a92216f to
71e2199
Compare
Collaborator
Author
|
@Keats I've considered renaming |
Keats
approved these changes
Jun 1, 2026
Owner
|
Ok to rename to as_bytes |
arckoor
force-pushed
the
raw-key-api-rework
branch
from
71e2199 to
f57a186
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Signers / Verifiers except the HMAC ones manually verify the key family at construction, so do that for HMAC too.
Main motivation is that after exposing
as_bytesin #452, theDecodingKeyKind::RsaModulusExponent { .. } => unreachable!()case is very much reachable by accident