fix(cli): read kernel metadata and source files using UTF-8 in kernels_push#1093
Open
sridipbasu wants to merge 1 commit into
Open
fix(cli): read kernel metadata and source files using UTF-8 in kernels_push#1093sridipbasu wants to merge 1 commit into
sridipbasu wants to merge 1 commit into
Conversation
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
kernels_push()to explicitly read the kernel metadata and source files using UTF-8 instead of relying on the platform's default encoding.Problem
On Windows systems where the default text encoding is not UTF-8, running:
kaggle kernels push -p .can fail with an error similar to:
This happens because
kernel-metadata.jsonand the kernel source file are opened without specifying an encoding. If either file contains Unicode characters (for example emojis, accented characters, or non-English text), reading the file may fail depending on the system's default encoding.Solution
This PR adds
encoding="utf-8"to the two file reads inkernels_push():kernel-metadata.json.py,.ipynb, etc.)This makes file reading consistent across platforms while preserving the existing behavior.
Tests
Added a regression test that:
kernels_push()reads them successfully.Why this change is safe
open()calls insidekernels_push().