ModCheckerPlugin#10
Closed
Slippers32 wants to merge 3 commits into
Closed
Conversation
added 2 commits
April 6, 2026 00:45
ArtemBalakin
reviewed
Apr 9, 2026
ArtemBalakin
left a comment
ArtemBalakin
left a comment
There was a problem hiding this comment.
Мелкие баги пофикси, крупные можешь просто объяснить, как бы поправил. ( если считаешь, что что-то не багуля- смело говори)
| String action = plugin.getConfig().getString(configPath, "LOG").toUpperCase(); | ||
|
|
||
| Bukkit.getScheduler().runTask(plugin, () -> { | ||
| switch (action) { |
There was a problem hiding this comment.
а прикинь действий будет не 3, а хотя бы 10, получится очень веселый свитч, правда? Как думаешь как можно пофиксить
|
|
||
| public PluginMessageHandler(ModCheckerPlugin plugin) { | ||
| this.plugin = plugin; | ||
| this.validator = new Validator(plugin); |
There was a problem hiding this comment.
А если тебе валидатор понадобится с другой логикой тут? Видишь проблему ?
| <option name="env"> | ||
| <map> | ||
| <entry key="TEST_PLUGIN_BUILD" value="1" /> | ||
| <entry key="SERVER_PATH" value="C:\DEV\TestServer" /> |
|
|
||
| public class JoinListener implements Listener { | ||
| private final ModCheckerPlugin plugin; | ||
| public static final Set<UUID> VERIFIED = new HashSet<>(); |
There was a problem hiding this comment.
Для таких штук лучше делать что-то тип репозитория(который CRUD) , а то в одном месте сделаешь очистку и будешь весело искать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Это серверная часть проверки клиента на запрещеные моды